Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] move page_retain_order to the same level as radius #2250

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

PwzXxm
Copy link
Contributor

@PwzXxm PwzXxm commented Sep 3, 2024

issue: milvus-io/milvus#35464

Signed-off-by: Patrick Weizhi Xu [email protected]
(cherry picked from commit 358d0dc)

@PwzXxm PwzXxm changed the title fix: move page_retain_order to the same level as radius fix: [2.4] move page_retain_order to the same level as radius Sep 3, 2024
@PwzXxm
Copy link
Contributor Author

PwzXxm commented Sep 3, 2024

/hold

Signed-off-by: Patrick Weizhi Xu <[email protected]>
(cherry picked from commit d742f77)
@PwzXxm
Copy link
Contributor Author

PwzXxm commented Sep 3, 2024

/unhold

Copy link
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PwzXxm, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 07052c5 into milvus-io:2.4 Sep 3, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants